Fixes #26873 - fix vsphere networks (auto)-loading #6803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26873 |
|
Thanks @timogoebel for your help on IRC! |
|
@ezr-ondrej: What do you think about this? |
|
[test] |
|
[test foreman] [test katello] |
|
I guess the failed tests are not related to my change. |
ezr-ondrej
reviewed
May 27, 2019
|
And thanks @sbernhard for issuing that! I haven't though about such simple solution 🤷♂️ |
Due to a race condition, sometimes the the failure 'uninitialized constant Fog::Compute::Vsphere::Network' happens when using the compute-resource networks API. Similar happend to Fog::Compute::Vsphere::Cluster
sbernhard
force-pushed
the
fix_vsphere_network
branch
from
0082e90
to
4486b02
Compare
|
Thanks @ezr-ondrej. It wasn't my idea to fix it this way - its @timogoebel :-) I did just run some tests. |
ezr-ondrej
approved these changes
May 27, 2019
|
1.22 - 8dbe4c5 |
pretty easy to verify, our container based environment is based on puma, maybe you can just give it a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a race condition, sometimes the the failure 'uninitialized constant Fog::Compute::Vsphere::Network' happens when using the compute-resource networks API.